Translate: make URL handling logic more readable

Translate: make URL handling logic more readable

BUG=none
TEST=browser_tests --gtest_filter='TranslateManagerTest.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193000

[Takashi Toyoshima, 2013-04-08 12:05:18]

Hi mad,

This is the CL I mentioned in issue 13488014.
Can you take a look?

[MAD, 2013-04-08 17:00:10]

LGTM, thanks again!

Just a small question...

BYE
MAD

https://codereview.chromium.org/13508007/diff/4001/chrome/browser/translate/t...
File chrome/browser/translate/translate_manager.cc (left):

https://codereview.chromium.org/13508007/diff/4001/chrome/browser/translate/t...
chrome/browser/translate/translate_manager.cc:646:
DCHECK(!page_url.SchemeIsSecure());
Did you feel this DCHECK is not useful anymore, or you removed it by mistake?

[Takashi Toyoshima, 2013-04-08 17:07:02]

https://codereview.chromium.org/13508007/diff/4001/chrome/browser/translate/t...
File chrome/browser/translate/translate_manager.cc (left):

https://codereview.chromium.org/13508007/diff/4001/chrome/browser/translate/t...
chrome/browser/translate/translate_manager.cc:646:
DCHECK(!page_url.SchemeIsSecure());
Actually, I enabled error report on secure URLs and I should remove this DCHECK
at that time... So this is intended change.

[MAD, 2013-04-08 18:00:35]

OK, cool... Thanks!


On Mon, Apr 8, 2013 at 1:07 PM, <toyoshim@chromium.org> wrote:

>
> https://codereview.chromium.**org/13508007/diff/4001/chrome/**
>
browser/translate/translate_**manager.cc<https://codereview.chromium.org/13508007/diff/4001/chrome/browser/translate/translate_manager.cc>
> File chrome/browser/translate/**translate_manager.cc (left):
>
> https://codereview.chromium.**org/13508007/diff/4001/chrome/**
>
browser/translate/translate_**manager.cc#oldcode646<https://codereview.chromium.org/13508007/diff/4001/chrome/browser/translate/translate_manager.cc#oldcode646>
> chrome/browser/translate/**translate_manager.cc:646:
> DCHECK(!page_url.**SchemeIsSecure());
> Actually, I enabled error report on secure URLs and I should remove this
> DCHECK at that time... So this is intended change.
>
>
https://codereview.chromium.**org/13508007/<https://codereview.chromium.org/1...
>

[Takashi Toyoshima, 2013-04-09 04:27:05]

Committed patchset #4 manually as r193000 (presubmit successful).