content/renderer/pepper/pepper_plugin_delegate_impl.cc - Issue 13508005: Allow RequestOSFileHandle if an app has unlimited storage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_delegate_impl.cc

Issue 13508005: Allow RequestOSFileHandle if an app has unlimited storage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert most of patch set 2 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/fileapi/fileapi_message_filter.cc ('K') | « content/renderer/pepper/pepper_file_io_host.cc ('k') | webkit/fileapi/file_system_callback_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_plugin_delegate_impl.cc

diff --git a/content/renderer/pepper/pepper_plugin_delegate_impl.cc b/content/renderer/pepper/pepper_plugin_delegate_impl.cc

index d2be7ccb80dc8d3e576f38d2d4118ac9ed7013ce..335cd02bbd10ab0dbeee56561837366d10fa1382 100644

--- a/content/renderer/pepper/pepper_plugin_delegate_impl.cc

+++ b/content/renderer/pepper/pepper_plugin_delegate_impl.cc

@@ -295,6 +295,7 @@ class AsyncOpenFileSystemURLCallbackTranslator

base::PlatformFile invalid_file = base::kInvalidPlatformFileValue;

callback_.Run(error_code,

base::PassPlatformFile(&invalid_file),

+ quota::kQuotaLimitTypeUnknown,

webkit::ppapi::PluginDelegate::NotifyCloseFileCallback());

}

@@ -302,9 +303,11 @@ class AsyncOpenFileSystemURLCallbackTranslator

NOTREACHED();

}

- virtual void DidOpenFile(base::PlatformFile file) OVERRIDE {

+ virtual void DidOpenFile(base::PlatformFile file,

+ quota::QuotaLimitType quota_policy) OVERRIDE {

callback_.Run(base::PLATFORM_FILE_OK,

base::PassPlatformFile(&file),

+ quota_policy,

close_file_callback_);

// Make sure we won't leak file handle if the requester has died.

if (file != base::kInvalidPlatformFileValue) {