Allow RequestOSFileHandle if an app has unlimited storage

content/browser/fileapi/fileapi_message_filter.cc

Index: content/browser/fileapi/fileapi_message_filter.cc
diff --git a/content/browser/fileapi/fileapi_message_filter.cc b/content/browser/fileapi/fileapi_message_filter.cc
index 7472115213db042bb44b6e3fc10a9ee4b1b1d499..7fe11c843eec0e51edebbd08d9c35d6848558e7b 100644
--- a/content/browser/fileapi/fileapi_message_filter.cc
+++ b/content/browser/fileapi/fileapi_message_filter.cc
@@ -35,6 +35,7 @@
 #include "webkit/fileapi/isolated_context.h"
 #include "webkit/fileapi/local_file_system_operation.h"
 #include "webkit/fileapi/sandbox_mount_point_provider.h"
+#include "webkit/quota/quota_manager.h"
 
 using fileapi::FileSystemFileUtil;
 using fileapi::FileSystemMountPointProvider;
@@ -691,9 +692,35 @@ void FileAPIMessageFilter::DidOpenFile(int request_id,
             IPC::GetFileHandleForProcess(file, peer_handle, true) :
             IPC::InvalidPlatformFileForTransit();
     open_filesystem_urls_.insert(path);
-    Send(new FileSystemMsg_DidOpenFile(request_id, file_for_transit));
+
+    quota::QuotaPolicy quota_policy = quota::kQuotaPolicyUnknown;
+    quota::QuotaManagerProxy* quota_manager_proxy =
+        context_->quota_manager_proxy();
+    DCHECK(quota_manager_proxy);
+    DCHECK(quota_manager_proxy->quota_manager());

[dmichael (off chromium), 2013/04/05 15:39:28]

If quota_manager_proxy is ever actually NULL, you'll dereference a NULL pointer
on 702 in a release build. It might be better to use CHECK().

Otherwise, you might just want the if, but in the else use NOTREACHED and maybe
send DidFail.

[hamaji, 2013/04/05 17:00:49]

Done, by CHECK

On 2013/04/05 15:39:28, dmichael wrote:

+    FileSystemURL url = context_->CrackURL(path);
+    if (quota_manager_proxy->quota_manager()->IsStorageUnlimited(
+            url.origin(), FileSystemTypeToQuotaStorageType(url.type()))) {
+      // TODO(hamaji): We are planning to introduce a special
+      // permission which is stronger than unlimitedStorage.
+      // We'll return kQuotaPolicyCanBypassCheck for apps with
+      // unlimitedStorage for now, but ideally, we should return
+      // kQuotaPolicyCanBypassCheck only when the app has the
+      // special permission.
+      // TODO(hamaji): Return kQuotaPolicyCanBypassCheck only for
+      // dev channels for the meantime.
+      // http://crbug.com/220029
+      quota_policy = quota::kQuotaPolicyCanBypassCheck;
+    } else {
+      quota_policy = quota::kQuotaPolicyCheckRequired;
+    }
+
+    Send(new FileSystemMsg_DidOpenFile(request_id,
+                                       file_for_transit,
+                                       quota_policy));
   } else {
-    Send(new FileSystemMsg_DidFail(request_id, result));
+    Send(new FileSystemMsg_DidFail(request_id,
+                                   result));
   }
   UnregisterOperation(request_id);
 }