Allow RequestOSFileHandle if an app has unlimited storage

content/renderer/pepper/pepper_file_io_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_file_io_host.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_util_proxy.h"
@@ skipping 94 matching lines @@
 }
 
 }  // namespace
 
 PepperFileIOHost::PepperFileIOHost(RendererPpapiHost* host,
                                    PP_Instance instance,
                                    PP_Resource resource)
     : ResourceHost(host->GetPpapiHost(), instance, resource),
       file_(base::kInvalidPlatformFileValue),
       file_system_type_(PP_FILESYSTEMTYPE_INVALID),
+      quota_limit_type_(quota::kQuotaLimitTypeUnknown),
       is_running_in_process_(host->IsRunningInProcess()),
       weak_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
   // TODO(victorhsieh): eliminate plugin_delegate_ as it's no longer needed.
   webkit::ppapi::PluginInstance* plugin_instance =
       webkit::ppapi::HostGlobals::Get()->GetInstance(instance);
   plugin_delegate_ = plugin_instance ? plugin_instance->delegate() : NULL;
 }
 
 PepperFileIOHost::~PepperFileIOHost() {
   OnHostMsgClose(NULL);
@@ skipping 322 matching lines @@
                      context->MakeReplyMessageContext())))
     return PP_ERROR_FAILED;
 
   state_manager_.SetPendingOperation(FileIOStateManager::OPERATION_EXCLUSIVE);
   return PP_OK_COMPLETIONPENDING;
 }
 
 int32_t PepperFileIOHost::OnHostMsgRequestOSFileHandle(
     ppapi::host::HostMessageContext* context) {
   if (!is_running_in_process_ &&
+      quota_limit_type_ != quota::kQuotaLimitTypeUnlimited &&
+      // TODO(hamaji): Remove the whitelist once it turned out the
+      // quota check is sufficient. http://crbug.com/226386
       !GetContentClient()->renderer()->IsRequestOSFileHandleAllowedForURL(
           file_system_url_))
     return PP_ERROR_FAILED;
 
-  // TODO(hamaji): Should fail if quota is not unlimited.
-  // http://crbug.com/224123
-
   RendererPpapiHost* renderer_ppapi_host =
       RendererPpapiHost::GetForPPInstance(pp_instance());
 
   IPC::PlatformFileForTransit file =
       renderer_ppapi_host->ShareHandleWithRemote(file_, false);
   if (file == IPC::InvalidPlatformFileForTransit())
     return PP_ERROR_FAILED;
   ppapi::host::ReplyMessageContext reply_context =
       context->MakeReplyMessageContext();
   reply_context.params.AppendHandle(ppapi::proxy::SerializedHandle(
@@ skipping 52 matching lines @@
 
   reply_context.params.set_result(pp_error);
   host()->SendReply(reply_context, PpapiPluginMsg_FileIO_OpenReply());
   state_manager_.SetOperationFinished();
 }
 
 void PepperFileIOHost::ExecutePlatformOpenFileSystemURLCallback(
     ppapi::host::ReplyMessageContext reply_context,
     base::PlatformFileError error_code,
     base::PassPlatformFile file,
+    quota::QuotaLimitType quota_limit_type,
     const PluginDelegate::NotifyCloseFileCallback& callback) {
   if (error_code == base::PLATFORM_FILE_OK)
     notify_close_file_callback_ = callback;
+  //quota_limit_type_ = quota_limit_type;

[kinuko, 2013/04/04 11:01:42]

need to comment this in?

[hamaji, 2013/04/04 11:50:12]

Wow :) Done.

   ExecutePlatformOpenFileCallback(reply_context, error_code, file);
 }
 
 void PepperFileIOHost::ExecutePlatformQueryCallback(
     ppapi::host::ReplyMessageContext reply_context,
     base::PlatformFileError error_code,
     const base::PlatformFileInfo& file_info) {
   PP_FileInfo pp_info;
   pp_info.size = file_info.size;
   pp_info.creation_time = TimeToPPTime(file_info.creation_time);
@@ skipping 44 matching lines @@
   // On the plugin side, the callback expects a parameter with different meaning
   // depends on whether is negative or not. It is the result here. We translate
   // for the callback.
   int32_t pp_error = ::ppapi::PlatformFileErrorToPepperError(error_code);
   reply_context.params.set_result(ErrorOrByteNumber(pp_error, bytes_written));
   host()->SendReply(reply_context, PpapiPluginMsg_FileIO_GeneralReply());
   state_manager_.SetOperationFinished();
 }
 
 }  // namespace content