StackFrameIterator looks up code object earlier to decide frame type.

src/heap/spaces.cc

Index: src/heap/spaces.cc
diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc
index 9bba6dd89b9cfe6e3e3ba0933d6d89b87dfc78ca..4a1e119d34bed68506dff4b1eb11cc6cbd97de5f 100644
--- a/src/heap/spaces.cc
+++ b/src/heap/spaces.cc
@@ -3033,6 +3033,15 @@ bool LargeObjectSpace::Contains(HeapObject* object) {
 }
 
 
+bool LargeObjectSpace::Contains(Address address) {

[Hannes Payer (out of office), 2015/09/22 16:31:23]

We have FindPage or FindObject (depending on what you want) which tells you if
an address is in LO space.

[titzer, 2015/09/23 09:33:57]

Ok, I can implement this method in terms of FindPage() which uses a hashtable
inside instead of the linear search. How many pages do we typically have in the
large object space? BTW do we really need a hashtable for that or could a binary
search be fine?

+  for (LargePage* chunk = first_page_; chunk != NULL;
+       chunk = chunk->next_page()) {
+    if (chunk->Contains(address)) return true;
+  }
+  return false;
+}
+
+
 #ifdef VERIFY_HEAP
 // We do not assume that the large object iterator works, because it depends
 // on the invariants we are checking during verification.