StackFrameIterator looks up code object earlier to decide frame type.

src/heap/spaces.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/heap/spaces.h"
 
 #include "src/base/bits.h"
 #include "src/base/platform/platform.h"
 #include "src/full-codegen/full-codegen.h"
 #include "src/heap/slots-buffer.h"
@@ skipping 3015 matching lines @@
   MemoryChunk* chunk = MemoryChunk::FromAddress(address);
 
   bool owned = (chunk->owner() == this);
 
   SLOW_DCHECK(!owned || FindObject(address)->IsHeapObject());
 
   return owned;
 }
 
 
+bool LargeObjectSpace::Contains(Address address) {

[Hannes Payer (out of office), 2015/09/22 16:31:23]

We have FindPage or FindObject (depending on what you want) which tells you if
an address is in LO space.

[titzer, 2015/09/23 09:33:57]

Ok, I can implement this method in terms of FindPage() which uses a hashtable
inside instead of the linear search. How many pages do we typically have in the
large object space? BTW do we really need a hashtable for that or could a binary
search be fine?

+  for (LargePage* chunk = first_page_; chunk != NULL;
+       chunk = chunk->next_page()) {
+    if (chunk->Contains(address)) return true;
+  }
+  return false;
+}
+
+
 #ifdef VERIFY_HEAP
 // We do not assume that the large object iterator works, because it depends
 // on the invariants we are checking during verification.
 void LargeObjectSpace::Verify() {
   for (LargePage* chunk = first_page_; chunk != NULL;
        chunk = chunk->next_page()) {
     // Each chunk contains an object that starts at the large object page's
     // object area start.
     HeapObject* object = chunk->GetObject();
     Page* page = Page::FromAddress(object->address());
@@ skipping 98 matching lines @@
     object->ShortPrint();
     PrintF("\n");
   }
   printf(" --------------------------------------\n");
   printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
 }
 
 #endif  // DEBUG
 }  // namespace internal
 }  // namespace v8