Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 135073002: Mojo: Add the beginnings of a proper embedder API. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add the beginnings of a proper embedder API. Actually, just move mojo::system::CoreImpl::Init() to mojo::embedder::Init(), in its own header file. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244284

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -10 lines) Patch
M mojo/common/test/run_all_perftests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/test/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/shell/context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/core_impl.h View 1 4 chunks +9 lines, -4 lines 0 comments Download
A mojo/system/embedder.h View 1 chunk +18 lines, -0 lines 0 comments Download
A mojo/system/embedder.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
WDYT? Notes: - I intend to add more embedder APIs, but I need a place ...
6 years, 11 months ago (2014-01-10 22:46:09 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/135073002/diff/1/mojo/system/core_impl.h File mojo/system/core_impl.h (right): https://codereview.chromium.org/135073002/diff/1/mojo/system/core_impl.h#newcode88 mojo/system/core_impl.h:88: friend void ::mojo::embedder::Init(); it doesn't work to just ...
6 years, 11 months ago (2014-01-10 22:48:54 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/135073002/diff/1/mojo/system/core_impl.h File mojo/system/core_impl.h (right): https://codereview.chromium.org/135073002/diff/1/mojo/system/core_impl.h#newcode88 mojo/system/core_impl.h:88: friend void ::mojo::embedder::Init(); On 2014/01/10 22:48:54, darin wrote: ...
6 years, 11 months ago (2014-01-11 00:30:37 UTC) #3
viettrungluu
6 years, 11 months ago (2014-01-11 00:31:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r244284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698