content/browser/frame_host/navigator_impl.cc - Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index b03e23232008f6d935da400a57fa968a2fc1965c..efd1f6537bcb8c6c664499904bce998c784f4310 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -486,7 +486,8 @@ void NavigatorImpl::DidNavigate(

params.url,

transition_type);

render_frame_host->navigation_handle()->DidCommitNavigation(

- is_navigation_within_page);

+ is_navigation_within_page, render_frame_host);

+ render_frame_host->SetNavigationHandle(nullptr);

}

if (!did_navigate)

@@ -739,7 +740,6 @@ void NavigatorImpl::CommitNavigation(FrameTreeNode* frame_tree_node,

render_frame_host, navigation_request->common_params().url);

navigation_request->TransferNavigationHandleOwnership(render_frame_host);

- delegate_->ReadyToCommitNavigation(render_frame_host->navigation_handle());

render_frame_host->CommitNavigation(response, body.Pass(),

navigation_request->common_params(),

navigation_request->request_params());

@@ -770,7 +770,6 @@ void NavigatorImpl::FailedNavigation(FrameTreeNode* frame_tree_node,

render_frame_host, navigation_request->common_params().url);

navigation_request->TransferNavigationHandleOwnership(render_frame_host);

- delegate_->ReadyToCommitNavigation(render_frame_host->navigation_handle());

render_frame_host->FailedNavigation(navigation_request->common_params(),

navigation_request->request_params(),

has_stale_copy_in_cache, error_code);