Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSE RVER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSE RVER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSE RVER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSE RVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "components/page_load_metrics/common/page_load_timing.h" 10 #include "components/page_load_metrics/common/page_load_timing.h"
(...skipping 16 matching lines...) Expand all
27 // IPC messages received from a MetricsRenderFrameObserver. 27 // IPC messages received from a MetricsRenderFrameObserver.
28 class MetricsWebContentsObserver 28 class MetricsWebContentsObserver
29 : public content::WebContentsObserver, 29 : public content::WebContentsObserver,
30 public content::WebContentsUserData<MetricsWebContentsObserver> { 30 public content::WebContentsUserData<MetricsWebContentsObserver> {
31 public: 31 public:
32 ~MetricsWebContentsObserver() override; 32 ~MetricsWebContentsObserver() override;
33 33
34 // content::WebContentsObserver implementation: 34 // content::WebContentsObserver implementation:
35 bool OnMessageReceived(const IPC::Message& message, 35 bool OnMessageReceived(const IPC::Message& message,
36 content::RenderFrameHost* render_frame_host) override; 36 content::RenderFrameHost* render_frame_host) override;
37 void DidCommitNavigation( 37 void DidFinishNavigation(
38 content::NavigationHandle* navigation_handle) override; 38 content::NavigationHandle* navigation_handle) override;
39 void RenderProcessGone(base::TerminationStatus status) override; 39 void RenderProcessGone(base::TerminationStatus status) override;
40 40
41 private: 41 private:
42 explicit MetricsWebContentsObserver(content::WebContents* web_contents); 42 explicit MetricsWebContentsObserver(content::WebContents* web_contents);
43 friend class content::WebContentsUserData<MetricsWebContentsObserver>; 43 friend class content::WebContentsUserData<MetricsWebContentsObserver>;
44 friend class MetricsWebContentsObserverTest; 44 friend class MetricsWebContentsObserverTest;
45 45
46 void OnTimingUpdated(content::RenderFrameHost*, const PageLoadTiming& timing); 46 void OnTimingUpdated(content::RenderFrameHost*, const PageLoadTiming& timing);
47 void RecordTimingHistograms(); 47 void RecordTimingHistograms();
48 48
49 bool IsRelevantNavigation(content::NavigationHandle* navigation_handle); 49 bool IsRelevantNavigation(content::NavigationHandle* navigation_handle);
50 50
51 // Will be null before any navigations have committed. When a navigation 51 // Will be null before any navigations have committed. When a navigation
52 // commits we will initialize this as empty. 52 // commits we will initialize this as empty.
53 scoped_ptr<PageLoadTiming> current_timing_; 53 scoped_ptr<PageLoadTiming> current_timing_;
54 54
55 DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver); 55 DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
56 }; 56 };
57 57
58 } // namespace page_load_metrics 58 } // namespace page_load_metrics
59 59
60 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_O BSERVER_H_ 60 #endif // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_O BSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698