Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 1350653004: [sessions] Properly namespace recently-componentized TabRestore code (Closed)

Created:
5 years, 3 months ago by blundell
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, kalyank, chromium-apps-reviews_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sessions] Properly namespace recently-componentized TabRestore code This CL puts all the core TabRestore code that was recently componentized in the sessions namespace. BUG=371476 TBR=sky Committed: https://crrev.com/74001adc667974152b861eda769a750da4242b73 Cr-Commit-Position: refs/heads/master@{#349648}

Patch Set 1 #

Patch Set 2 : Fix Android #

Patch Set 3 : Fix Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -433 lines) Patch
M chrome/browser/android/recently_closed_tabs_bridge.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/recently_closed_tabs_bridge.cc View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.h View 3 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/sessions/sessions_api.cc View 12 chunks +33 lines, -28 lines 0 comments Download
M chrome/browser/jumplist_win.h View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 6 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/sessions/chrome_tab_restore_service_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/chrome_tab_restore_service_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_browsertest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sessions/persistent_tab_restore_service_unittest.cc View 24 chunks +56 lines, -48 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 5 chunks +19 lines, -13 lines 0 comments Download
M chrome/browser/sessions/session_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_browsertest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_factory.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_factory.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_delegate.cc View 4 chunks +15 lines, -12 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_tab_restorer.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_tabrestore_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 6 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 8 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.h View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 7 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sessions/base_session_service_commands.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/content/content_tab_client_data.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.h View 3 chunks +9 lines, -8 lines 0 comments Download
M components/sessions/core/in_memory_tab_restore_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sessions/core/live_tab.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sessions/core/persistent_tab_restore_service.h View 3 chunks +13 lines, -8 lines 0 comments Download
M components/sessions/core/persistent_tab_restore_service.cc View 23 chunks +70 lines, -82 lines 0 comments Download
M components/sessions/core/serialized_navigation_driver.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sessions/core/tab_restore_service.h View 7 chunks +10 lines, -9 lines 0 comments Download
M components/sessions/core/tab_restore_service.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/sessions/core/tab_restore_service_client.h View 2 chunks +2 lines, -8 lines 0 comments Download
M components/sessions/core/tab_restore_service_delegate.h View 3 chunks +11 lines, -12 lines 0 comments Download
M components/sessions/core/tab_restore_service_helper.h View 7 chunks +15 lines, -15 lines 0 comments Download
M components/sessions/core/tab_restore_service_helper.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M components/sessions/core/tab_restore_service_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
blundell
Hi Scott, I'm going to TBR this, as it's just putting the sessions namespace around ...
5 years, 3 months ago (2015-09-18 10:34:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350653004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350653004/40001
5 years, 3 months ago (2015-09-18 10:35:16 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-18 11:04:31 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/74001adc667974152b861eda769a750da4242b73 Cr-Commit-Position: refs/heads/master@{#349648}
5 years, 3 months ago (2015-09-18 11:05:04 UTC) #6
sky
5 years, 3 months ago (2015-09-18 15:32:55 UTC) #7
Message was sent while issue was closed.
Rubber stamp LGTM

Powered by Google App Engine
This is Rietveld 408576698