Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135063003: Fixes for browser finder unittests on cros. (Closed)

Created:
6 years, 11 months ago by achuithb
Modified:
6 years, 11 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unittest
Visibility:
Public.

Description

Fixes for browser finder unittests on cros. These tests don't succeed because of desktop_browser_finder.CanFindAvailableBrowsers: https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py&q=CanFindAvailableBrowsers&l=84 BUG=331940 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -14 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py View 6 chunks +46 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
achuithb
Tim, please take a look.
6 years, 11 months ago (2014-01-10 23:46:08 UTC) #1
Tim Song
lgtm
6 years, 11 months ago (2014-01-11 00:07:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/135063003/1
6 years, 11 months ago (2014-01-11 02:22:22 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 02:59:53 UTC) #4
Message was sent while issue was closed. 
Change committed as 244424

Powered by Google App Engine
This is Rietveld 408576698