Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1350563002: Override the Data Saver API proxy list in DRP integration tests. (Closed)

Created:
5 years, 3 months ago by sclittle
Modified:
5 years, 2 months ago
Reviewers:
bengr, bustamante
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flag_drp_proxies
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Override the Data Saver API proxy list in DRP integration tests. Use a flag to override the proxy list when using the Data Saver API for the relevant Data Reduction Proxy integration tests. This should fix the currently broken fallback_viaheader and http_to_direct_fallback tests. BUG=526827 Committed: https://crrev.com/386a4d6ab6f234cb64accb303192d840ef28a161 Cr-Commit-Position: refs/heads/master@{#351225}

Patch Set 1 #

Patch Set 2 : Updated flag string #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 1 2 chunks +12 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
sclittle
5 years, 3 months ago (2015-09-16 01:47:51 UTC) #2
bustamante
lgtm Cool, thanks!
5 years, 3 months ago (2015-09-16 18:55:40 UTC) #3
bengr
lgtm
5 years, 3 months ago (2015-09-18 22:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350563002/40001
5 years, 2 months ago (2015-09-29 00:42:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-29 01:30:09 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 01:30:58 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/386a4d6ab6f234cb64accb303192d840ef28a161
Cr-Commit-Position: refs/heads/master@{#351225}

Powered by Google App Engine
This is Rietveld 408576698