[Android WebView] Call shouldInterceptRequest on a background thread

android_webview/native/aw_contents_io_thread_client_impl.h

Index: android_webview/native/aw_contents_io_thread_client_impl.h
diff --git a/android_webview/native/aw_contents_io_thread_client_impl.h b/android_webview/native/aw_contents_io_thread_client_impl.h
index 97ba3146091604596ff47d6a80fdd61ac7726384..01d8747b1405c3f69deea97ddd1414c9da0c7bac 100644
--- a/android_webview/native/aw_contents_io_thread_client_impl.h
+++ b/android_webview/native/aw_contents_io_thread_client_impl.h
@@ -47,8 +47,9 @@ class AwContentsIoThreadClientImpl : public AwContentsIoThreadClient {
   // Implementation of AwContentsIoThreadClient.
   bool PendingAssociation() const override;
   CacheMode GetCacheMode() const override;
-  scoped_ptr<AwWebResourceResponse> ShouldInterceptRequest(
-      const net::URLRequest* request) override;
+  void ShouldInterceptRequestAsync(
+      const net::URLRequest* request,
+      const ShouldInterceptRequestResultCallback callback) override;
   bool ShouldBlockContentUrls() const override;
   bool ShouldBlockFileUrls() const override;
   bool ShouldAcceptThirdPartyCookies() const override;
@@ -69,6 +70,7 @@ class AwContentsIoThreadClientImpl : public AwContentsIoThreadClient {
  private:
   bool pending_association_;
   base::android::ScopedJavaGlobalRef<jobject> java_object_;
+  base::android::ScopedJavaGlobalRef<jobject> bg_thread_client_object_;

[boliu, 2015/10/01 19:13:56]

Sorry.. just noticed this will prevent AwContents from gc-ed. But I guess it's
ok since this is short-lived, only during the duration of the callback.

Just to be safe, maybe code the java class to only hold a reference to
mContentClient instead of all of AwContents?

Definitely worth a comment though, either way.

[mnaganov (inactive), 2015/10/01 19:51:04]

The lifetime and properties of BackgroundThreadClientImpl are absolutely the
same as of IoThreadClientImpl. We already hold a reference to IoThreadClientImpl
Java object here, so adding a reference to BackgroundThreadClientImpl doesn't
hurt.

I agree with your note about only holding mContentsClient rather than full
AwContents, but let's make that in another CL.

 
   DISALLOW_COPY_AND_ASSIGN(AwContentsIoThreadClientImpl);
 };