Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1634)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java

Issue 1350553005: [Android WebView] Call shouldInterceptRequest on a background thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed indent in AwStreamReaderJobDelegateImpl Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
index 61794004b7f5b060f3d6deaaea90faddade248b8..8e77a27ee2478ae2071cff0d2b896cbe88ea6d24 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java
@@ -40,8 +40,8 @@ public abstract class AwContentsIoThreadClient {
@CalledByNative
public abstract void newLoginRequest(String realm, String account, String args);
- public abstract AwWebResourceResponse shouldInterceptRequest(
- AwContentsClient.AwWebResourceRequest request);
+ @CalledByNative
+ public abstract AwContentsBackgroundThreadClient getBackgroundThreadClient();
public abstract void onReceivedError(AwContentsClient.AwWebResourceRequest request,
AwContentsClient.AwWebResourceError error);
@@ -52,23 +52,6 @@ public abstract class AwContentsIoThreadClient {
// Protected methods ---------------------------------------------------------------------------
@CalledByNative
- protected AwWebResourceResponse shouldInterceptRequest(String url, boolean isMainFrame,
- boolean hasUserGesture, String method, String[] requestHeaderNames,
- String[] requestHeaderValues) {
- AwContentsClient.AwWebResourceRequest request =
- new AwContentsClient.AwWebResourceRequest();
- request.url = url;
- request.isMainFrame = isMainFrame;
- request.hasUserGesture = hasUserGesture;
- request.method = method;
- request.requestHeaders = new HashMap<String, String>(requestHeaderNames.length);
- for (int i = 0; i < requestHeaderNames.length; ++i) {
- request.requestHeaders.put(requestHeaderNames[i], requestHeaderValues[i]);
- }
- return shouldInterceptRequest(request);
- }
-
- @CalledByNative
protected void onReceivedError(
// WebResourceRequest
String url, boolean isMainFrame, boolean hasUserGesture, String method,

Powered by Google App Engine
This is Rietveld 408576698