Issue 135053006: Enable immersive fullscreen for non-browser windows by default

Issue 135053006: Enable immersive fullscreen for non-browser windows by default (Closed)

Created:
6 years, 11 months ago by pkotwicz

Modified:
6 years, 11 months ago

Reviewers:
James Cook, benwells

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable immersive fullscreen for non-browser windows by default. BUG=334473 TEST=None R=jamescook TBR=benwells (For trivial refactor in chrome/browser/ui/views/apps/native_app_window_views.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245075

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -17 lines)			Patch
M	ash/ash_switches.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/ash_switches.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	ash/wm/custom_frame_view_ash.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	ash/wm/window_state.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/accelerator_commands_browsertest.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/apps/native_app_window_views.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_ash.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

James, can you please take a look? I am turning the feature on so that ...

6 years, 11 months ago (2014-01-15 01:01:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/135053006/70001

6 years, 11 months ago (2014-01-15 17:40:12 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=246704

6 years, 11 months ago (2014-01-15 21:25:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/135053006/70001

6 years, 11 months ago (2014-01-15 23:52:23 UTC) #5

Message was sent while issue was closed.

Change committed as 245075

Expand Messages | Collapse Messages