Issue 1350503005: EDK: Some more scoped_ptr -> std::unique_ptr conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350503005: EDK: Some more scoped_ptr -> std::unique_ptr conversions. (Closed)

Created:
5 years, 3 months ago by viettrungluu

Modified:
5 years, 3 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Some more scoped_ptr -> std::unique_ptr conversions. After this, the remaining conversions in //mojo/edk/system are all for scoped_ptr<MessageInTransit> (I think), and there are (semi)public API changes in //mojo/edk/embedder. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a1e901b78eb06e799209b00b13d2104dbab1012b

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -31 lines)			Patch
M	mojo/edk/system/channel.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel_test_base.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel_test_base.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	mojo/edk/system/data_pipe_impl_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	mojo/edk/system/ipc_support.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	mojo/edk/system/master_connection_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/edk/system/raw_channel_posix.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	mojo/edk/system/raw_channel_unittest.cc	View	10 chunks	+12 lines, -12 lines	0 comments	Download
M	mojo/edk/system/slave_connection_manager.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 3 months ago (2015-09-18 01:15:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a1e901b78eb06e799209b00b13d2104dbab1012b (presubmit successful).

Expand Messages | Collapse Messages