mojo/edk/system/raw_channel.cc - Issue 1350503004: Some easy conversions of scoped_ptr -> std::unique_ptr in the EDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/raw_channel.cc

Issue 1350503004: Some easy conversions of scoped_ptr -> std::unique_ptr in the EDK. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/raw_channel.cc

diff --git a/mojo/edk/system/raw_channel.cc b/mojo/edk/system/raw_channel.cc

index 20f74d28de86d1a2c320663ed2c2f1cbea1afd48..0f89bc3e054067e1d84a427ff361b66fd1bfe420 100644

--- a/mojo/edk/system/raw_channel.cc

+++ b/mojo/edk/system/raw_channel.cc

@@ -7,6 +7,7 @@

#include <string.h>

#include <algorithm>

+#include <utility>

#include "base/bind.h"

#include "base/location.h"

@@ -217,7 +218,7 @@ void RawChannel::Shutdown() {

write_stopped_ = true;

weak_ptr_factory_.InvalidateWeakPtrs();

- OnShutdownNoLock(read_buffer_.Pass(), write_buffer_.Pass());

+ OnShutdownNoLock(std::move(read_buffer_), std::move(write_buffer_));

}

// Reminder: This must be thread-safe.

« no previous file with comments | « mojo/edk/system/raw_channel.h ('k') | mojo/edk/system/raw_channel_posix.cc » ('j') | no next file with comments »