base/win/pe_image_test.cc - Issue 1350493002: Check for CloseHandle failures even when not debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/win/pe_image_test.cc

Issue 1350493002: Check for CloseHandle failures even when not debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code tweaks Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/win/pe_image_test.cc

diff --git a/base/win/pe_image_test.cc b/base/win/pe_image_test.cc

index e374598ada750f1d41907807a173f4ba933d18e7..24bf6d2996b3cf66062a132117b2e3d858a31fbb 100644

--- a/base/win/pe_image_test.cc

+++ b/base/win/pe_image_test.cc

@@ -25,7 +25,7 @@ __declspec(dllexport) void ExportFunc2() {

// Call into kernel32.dll.

HANDLE h = CreateEvent(NULL, FALSE, FALSE, NULL);

- CloseHandle(h);

+ CHECK(::CloseHandle(h));

rvargas (doing something else) 2015/09/16 02:09:12 This is never executed, so I would not change this

brucedawson 2015/09/16 18:29:00 Ignore this change. I'm reverting it. The CHECK do

brucedawson 2015/09/16 18:29:00 Done.

}

} // extern "C"

« base/win/object_watcher_unittest.cc ('K') | « base/win/object_watcher_unittest.cc ('k') | no next file » | no next file with comments »