Check for CloseHandle failures even when not debugging

base/process/kill_win.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/kill.h"
 
 #include <io.h>
 #include <windows.h>
 
 #include "base/bind.h"
@@ skipping 141 matching lines @@
                             const ProcessFilter* filter) {
   bool result = true;
   DWORD start_time = GetTickCount();
 
   NamedProcessIterator iter(executable_name, filter);
   for (const ProcessEntry* entry = iter.NextProcessEntry(); entry;
        entry = iter.NextProcessEntry()) {
     DWORD remaining_wait = static_cast<DWORD>(std::max(
         static_cast<int64>(0),
         wait.InMilliseconds() - (GetTickCount() - start_time)));
-    HANDLE process = OpenProcess(SYNCHRONIZE,
+    base::win::ScopedHandle process(OpenProcess(SYNCHRONIZE,

[grt (UTC plus 2), 2015/09/16 15:30:33]

    Process process(Process::OpenWithAccess(entry->th32ProcessID, SYNCHRONIZE));

[brucedawson, 2015/09/16 18:29:00]

Done.

                                  FALSE,
-                                 entry->th32ProcessID);
-    DWORD wait_result = WaitForSingleObject(process, remaining_wait);
-    CloseHandle(process);
+                                 entry->th32ProcessID));
+    DWORD wait_result = WaitForSingleObject(process.Get(), remaining_wait);

[grt (UTC plus 2), 2015/09/16 15:30:33]

process.Handle()

[grt (UTC plus 2), 2015/09/16 15:30:33]

should this check process.IsValid() before trying to wait?

[brucedawson, 2015/09/16 18:29:00]

Done.

[brucedawson, 2015/09/16 18:29:00]

That seems like a separate change - I'm not sure what it achieves.

[grt (UTC plus 2), 2015/09/16 19:27:01]

I assume Wait will fail with an error if the handle is invalid. It looks like
there's a race here that will lead to the function returning false if a process
exits naturally between getting the pid and opening the handle. I'd argue that
this is wrong: false should mean that the function failed to wait for them all
to exit, not that some exited normally without needing a wait. This could be
something for another CL.

     result &= (wait_result == WAIT_OBJECT_0);
   }
 
   return result;
 }
 
 bool CleanupProcesses(const FilePath::StringType& executable_name,
                       TimeDelta wait,
                       int exit_code,
                       const ProcessFilter* filter) {
@@ skipping 12 matching lines @@
   }
 
   MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       Bind(&TimerExpiredTask::TimedOut,
            Owned(new TimerExpiredTask(process.Pass()))),
       TimeDelta::FromMilliseconds(kWaitInterval));
 }
 
 }  // namespace base