Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1350453004: Improve iOS localisation and resource packing. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
chromium-reviews, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve iOS localisation and resource packing. Stop using whitelisting for resources from components on the rationale that it causes confusion for the developers and most of those resources are used on iOS. Stop support for whitelisting for resources when using gn as meta-build system on the rationale that the migration will happen after Chrome on iOS is unforked at which point whitelisting will not be used with gyp either. Update build/ios/grit_whitelist.txt to: 1. remove all resources from //components, 2. remove all resources that no longer exists, 3. add all resources used downstream (i.e. unfork the file). TEST=Checked that clobber build compiled and all tests passed on both the upstream and downstream tree with this CL. BUG=429756 Committed: https://crrev.com/502be01eec9af4fa82ce8abe4f6470735288b5e4 Cr-Commit-Position: refs/heads/master@{#350526}

Patch Set 1 #

Patch Set 2 : Update build/ios/grit_whitelist.txt #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -433 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 36 chunks +138 lines, -429 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M components/components_resources.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M components/components_strings.gyp View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
sdefresne
stuartmorgan: can you review the main idea of not using whitelisting for //components resources? I ...
5 years, 3 months ago (2015-09-18 16:22:41 UTC) #2
Dirk Pranke
grit_rule.gni changes lgtm.
5 years, 3 months ago (2015-09-18 19:31:06 UTC) #3
stuartmorgan
Makes sense; lgtm If we run into specific components where unused resources are an issue, ...
5 years, 3 months ago (2015-09-22 13:17:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350453004/20001
5 years, 3 months ago (2015-09-22 14:44:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/100826)
5 years, 3 months ago (2015-09-22 14:47:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350453004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350453004/40001
5 years, 3 months ago (2015-09-22 15:10:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/107164)
5 years, 3 months ago (2015-09-22 15:46:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350453004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350453004/40001
5 years, 3 months ago (2015-09-23 08:16:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/116857)
5 years, 3 months ago (2015-09-23 15:47:05 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350453004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350453004/60001
5 years, 3 months ago (2015-09-24 08:51:40 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-24 10:48:21 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 10:49:15 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/502be01eec9af4fa82ce8abe4f6470735288b5e4
Cr-Commit-Position: refs/heads/master@{#350526}

Powered by Google App Engine
This is Rietveld 408576698