Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Issue 1350453002: Merge to XFA: Convert some unneeded gotos into returns. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Convert some unneeded gotos into returns. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1332193002 . (cherry picked from commit da0938f8671958aba0522a69fc687a7bbb01b435) Committed: https://pdfium.googlesource.com/pdfium/+/4babdcf9c7abc9edefb179e5ed23db8e7a5840f7

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -57 lines) Patch
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 1 3 chunks +49 lines, -57 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
TBR, clean merge.
5 years, 3 months ago (2015-09-15 23:25:53 UTC) #1
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-16 20:12:52 UTC) #2
Lei Zhang
Whoops, didn't actually land this one.
5 years, 3 months ago (2015-09-17 21:53:35 UTC) #3
Lei Zhang
5 years, 3 months ago (2015-09-17 21:53:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4babdcf9c7abc9edefb179e5ed23db8e7a5840f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698