Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135043007: Remove default parameter from virtual layoutBlock function (Closed)

Created:
6 years, 11 months ago by atreat
Modified:
6 years, 11 months ago
Reviewers:
esprehn, Inactive
CC:
blink-reviews, chromiumbugtracker_adobe.com, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove default parameter from virtual layoutBlock function Remove default parameter from virtual layoutBlock function since it is only called explicitly once on an instance of one particular overload of this method. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M Source/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMarquee.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMarquee.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderRegion.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
atreat
Looking into non-recursive layout and trying to simplify little bits as I go along.
6 years, 11 months ago (2014-01-16 21:12:41 UTC) #1
esprehn
lgtm
6 years, 11 months ago (2014-01-16 21:20:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/135043007/1
6 years, 11 months ago (2014-01-16 21:32:03 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 21:58:55 UTC) #4
Message was sent while issue was closed. 
Change committed as 165254

Powered by Google App Engine
This is Rietveld 408576698