Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 135043003: Remove private system API calls in dns_config_service_posix on iOS (Closed)

Created:
6 years, 11 months ago by droger
Modified:
6 years, 11 months ago
Reviewers:
szym, kiyun
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove private system API calls in dns_config_service_posix on iOS BUG=335000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245391

Patch Set 1 : Fix compile #

Total comments: 2

Patch Set 2 : Review comments #

Patch Set 3 : Fix compile again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -101 lines) Patch
M net/dns/dns_config_service_posix.cc View 1 2 5 chunks +28 lines, -100 lines 0 comments Download
A net/dns/dns_config_watcher_mac.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
A net/dns/dns_config_watcher_mac.cc View 1 1 chunk +106 lines, -0 lines 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
droger
6 years, 11 months ago (2014-01-16 11:11:14 UTC) #1
szym
lgtm https://codereview.chromium.org/135043003/diff/90001/net/dns/dns_config_service_posix.cc File net/dns/dns_config_service_posix.cc (right): https://codereview.chromium.org/135043003/diff/90001/net/dns/dns_config_service_posix.cc#newcode50 net/dns/dns_config_service_posix.cc:50: #elif !defined(OS_MACOSX) Add comment: // DnsConfigWatcher for OS_MACOSX ...
6 years, 11 months ago (2014-01-16 17:03:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/135043003/180001
6 years, 11 months ago (2014-01-16 17:23:11 UTC) #3
droger
Thanks for the review, I applied the comments.
6 years, 11 months ago (2014-01-16 17:23:21 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=116180
6 years, 11 months ago (2014-01-16 18:49:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/135043003/440001
6 years, 11 months ago (2014-01-16 19:08:54 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247572
6 years, 11 months ago (2014-01-16 22:23:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/135043003/440001
6 years, 11 months ago (2014-01-16 23:30:30 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 00:27:51 UTC) #9
Message was sent while issue was closed.
Change committed as 245391

Powered by Google App Engine
This is Rietveld 408576698