Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1350413002: Add debug symbols to all generated .isolate (bis). (Closed)

Created:
5 years, 3 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add debug symbols to all generated .isolate (bis). This will increase the amount of data being uploaded by a ~2x factor or so. Debug symbols are usually larger than the executable itself on pretty much all toolsets but generally have the advantage of being highly compressible. The increase of data not a problem anymore with isolate-go. There will be a small increase of latency but it should be bearable, especially by the gain of enabling stack traces to work for isolated tests on Swarming. R=jam@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/aad3ded46d115f94f1c501c5b21fa1ef73ef771b Cr-Commit-Position: refs/heads/master@{#349953}

Patch Set 1 : Original patch #

Patch Set 2 : Also look explicitly for .dylib files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -38 lines) Patch
M tools/isolate_driver.py View 1 4 chunks +101 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
M-A Ruel
If you compare: succeeding: https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=3124367d65e9cfefad53ca0be4a46aed8db04d74 failing: https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=f9d8e3cb7cc5752a9036bbe7e4bf9e9e5f094802 The main difference is that the one that ...
5 years, 3 months ago (2015-09-18 17:51:53 UTC) #1
jam
lgtm
5 years, 3 months ago (2015-09-21 16:51:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350413002/20001
5 years, 3 months ago (2015-09-21 16:54:58 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-21 17:36:12 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aad3ded46d115f94f1c501c5b21fa1ef73ef771b Cr-Commit-Position: refs/heads/master@{#349953}
5 years, 3 months ago (2015-09-21 17:37:20 UTC) #6
paulmeyer
5 years, 3 months ago (2015-09-21 18:56:39 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1359703002/ by paulmeyer@chromium.org.

The reason for reverting is: Broke many Mac tests, such as:
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%2....

Powered by Google App Engine
This is Rietveld 408576698