Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1350323002: Add slice tool (Closed)

Created:
5 years, 3 months ago by robertphillips
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add slice tool Don't know if we want to add this but I found it useful when tracking down blur circle bugs. Committed: https://skia.googlesource.com/skia/+/5ce341fcd7eb63fc98c182b34c5503fb1780faf5

Patch Set 1 #

Patch Set 2 : Fixed overlength line #

Patch Set 3 : Rename slice to imgslice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -0 lines) Patch
M gyp/tools.gyp View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M tools/flags/SkCommandLineFlags.h View 3 chunks +19 lines, -0 lines 0 comments Download
A tools/imgslice.cpp View 1 2 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
robertphillips
5 years, 3 months ago (2015-09-18 12:41:43 UTC) #2
reed1
lgtm
5 years, 3 months ago (2015-09-18 15:24:34 UTC) #3
reed1
maybe name it something more specific? image_slide or something?
5 years, 3 months ago (2015-09-18 15:24:56 UTC) #4
robertphillips
On 2015/09/18 15:24:56, reed1 wrote: > maybe name it something more specific? image_slide or something? ...
5 years, 3 months ago (2015-09-18 15:51:13 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350323002/40001
5 years, 3 months ago (2015-09-18 15:52:00 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 15:58:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350323002/40001
5 years, 3 months ago (2015-09-18 16:04:16 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 16:04:46 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5ce341fcd7eb63fc98c182b34c5503fb1780faf5

Powered by Google App Engine
This is Rietveld 408576698