Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350293002: Fix --hydrogen-stats crashing on null_ptr for shared_info (Closed)

Created:
5 years, 3 months ago by Camillo Bruni
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix --hydrogen-stats crashing on null_ptr for shared_info BUG= Committed: https://crrev.com/11c45e6d1eff1a8cc34561ec835cbdb38f0ab79d Cr-Commit-Position: refs/heads/master@{#30823}

Patch Set 1 #

Patch Set 2 : Removing accidental change #

Patch Set 3 : one too many #

Patch Set 4 : conditions are hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Camillo Bruni
PTAL
5 years, 3 months ago (2015-09-18 09:52:49 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-18 10:17:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350293002/20001
5 years, 3 months ago (2015-09-18 10:20:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/9756)
5 years, 3 months ago (2015-09-18 10:22:35 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350293002/40001
5 years, 3 months ago (2015-09-18 10:32:37 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350293002/60001
5 years, 3 months ago (2015-09-18 10:34:57 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 11:01:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350293002/60001
5 years, 3 months ago (2015-09-18 11:01:57 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-18 11:03:35 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 11:03:59 UTC) #19
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/11c45e6d1eff1a8cc34561ec835cbdb38f0ab79d
Cr-Commit-Position: refs/heads/master@{#30823}

Powered by Google App Engine
This is Rietveld 408576698