src/compiler/x64/code-generator-x64.cc - Issue 1350223006: binary-operator-reducer: reduce mul+div(shift)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 1350223006: binary-operator-reducer: reduce mul+div(shift) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: TruncateInt64ToFloat64 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x64/code-generator-x64.cc

diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc

index 56260804806fd904a506bf5c776b2ee7005cf200..317c17e9330d0b7716d58066bceba16f50e67e7f 100644

--- a/src/compiler/x64/code-generator-x64.cc

+++ b/src/compiler/x64/code-generator-x64.cc

@@ -928,6 +928,13 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {

}

__ cvtqsi2sd(i.OutputDoubleRegister(), kScratchRegister);

break;

+ case kSSEInt64ToFloat64:

+ if (instr->InputAt(0)->IsRegister()) {

+ __ cvtqsi2sd(i.OutputDoubleRegister(), i.InputRegister(0));

+ } else {

+ __ cvtqsi2sd(i.OutputDoubleRegister(), i.InputOperand(0));

+ }

+ break;

case kSSEFloat64ExtractLowWord32:

if (instr->InputAt(0)->IsDoubleStackSlot()) {

__ movl(i.OutputRegister(), i.InputOperand(0));