components/web_view/test_runner/test_runner_application_delegate.cc - Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/test_runner/test_runner_application_delegate.cc

Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/web_view/pending_web_view_load.h ('K') | « components/web_view/test_runner/test_runner_application_delegate.h ('k') | components/web_view/web_view_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/test_runner/test_runner_application_delegate.cc

diff --git a/components/web_view/test_runner/test_runner_application_delegate.cc b/components/web_view/test_runner/test_runner_application_delegate.cc

index e268677f7f9162ed21055ea333486c214559c70a..556ccdee68ec827bdc82a0be7b7428f462cd8582 100644

--- a/components/web_view/test_runner/test_runner_application_delegate.cc

+++ b/components/web_view/test_runner/test_runner_application_delegate.cc

@@ -115,11 +115,13 @@ void TestRunnerApplicationDelegate::OnConnectionLost(

////////////////////////////////////////////////////////////////////////////////

// mojom::WebViewClient implementation:

-void TestRunnerApplicationDelegate::TopLevelNavigate(

+void TestRunnerApplicationDelegate::TopLevelNavigateRequest(

mojo::URLRequestPtr request) {

web_view_->web_view()->LoadRequest(request.Pass());

}

+void TestRunnerApplicationDelegate::TopLevelNavigationStarted(

+ const mojo::String& url) {}

void TestRunnerApplicationDelegate::LoadingStateChanged(bool is_loading,

double progress) {}

void TestRunnerApplicationDelegate::BackForwardChanged(