components/web_view/pending_web_view_load.cc - Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/pending_web_view_load.cc

Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/web_view/pending_web_view_load.h ('K') | « components/web_view/pending_web_view_load.h ('k') | components/web_view/public/interfaces/web_view.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/pending_web_view_load.cc

diff --git a/components/web_view/pending_web_view_load.cc b/components/web_view/pending_web_view_load.cc

index 81fc34118c90a2ff09d04835cf81adada307c573..726cee73a256e077b5175a0ebe27876bb8ff3f75 100644

--- a/components/web_view/pending_web_view_load.cc

+++ b/components/web_view/pending_web_view_load.cc

@@ -18,6 +18,7 @@ PendingWebViewLoad::~PendingWebViewLoad() {}

void PendingWebViewLoad::Init(mojo::URLRequestPtr request) {

DCHECK(!frame_connection_);

+ pending_url_ = request->url;

frame_connection_.reset(new FrameConnection);

frame_connection_->Init(web_view_->app_, request.Pass(),

base::Bind(&PendingWebViewLoad::OnGotContentHandlerID,

@@ -27,7 +28,7 @@ void PendingWebViewLoad::Init(mojo::URLRequestPtr request) {

void PendingWebViewLoad::OnGotContentHandlerID() {

is_content_handler_id_valid_ = true;

if (web_view_->content_)

- web_view_->OnLoad();

+ web_view_->OnLoad(pending_url_);

// The else case is handled by WebViewImpl when it gets the View (|content_|).

}