Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: components/web_view/web_view_impl.cc

Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/web_view_apptest.cc ('k') | mandoline/ui/desktop_ui/browser_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/web_view_impl.cc
diff --git a/components/web_view/web_view_impl.cc b/components/web_view/web_view_impl.cc
index 84675d14f52f6670d1f8c0b979dd63f8bf2fd6c1..03075bea761f9e82964678ef6dadf65b4113ff18 100644
--- a/components/web_view/web_view_impl.cc
+++ b/components/web_view/web_view_impl.cc
@@ -175,7 +175,7 @@ void WebViewImpl::TitleChanged(const mojo::String& title) {
}
void WebViewImpl::NavigateTopLevel(Frame* source, mojo::URLRequestPtr request) {
- client_->TopLevelNavigate(request.Pass());
+ client_->TopLevelNavigateRequest(request.Pass());
}
void WebViewImpl::CanNavigateFrame(Frame* target,
@@ -197,13 +197,14 @@ void WebViewImpl::DidCommitProvisionalLoad(Frame* frame) {
void WebViewImpl::HandlePageNavigateRequest(const GURL& url) {
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = url.spec();
- client_->TopLevelNavigate(request.Pass());
+ client_->TopLevelNavigateRequest(request.Pass());
}
////////////////////////////////////////////////////////////////////////////////
// WebViewImpl, NavigationControllerDelegate implementation:
void WebViewImpl::OnNavigate(mojo::URLRequestPtr request) {
+ client_->TopLevelNavigationStarted(request->url);
sky 2015/09/21 14:59:46 Are you sure you don't want to notify from OnLoad?
sadrul 2015/09/23 04:32:14 That looks like a better place. Made this change.
pending_load_.reset(new PendingWebViewLoad(this));
pending_load_->Init(request.Pass());
}
« no previous file with comments | « components/web_view/web_view_apptest.cc ('k') | mandoline/ui/desktop_ui/browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698