Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1350223004: Split the GN 'snapshot_toolchain' logic out into an include file. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split the GN 'snapshot_toolchain' logic out into an include file. We need to build parts of v8 with a toolchain that might be different from both the default (target) toolchain and the regular host toolchain, because we need the snapshot to have the same bit-width as the target. V8's build defines a 'snapshot_toolchain' setting for this. It turns out that we need the value of this toolchain to be exposed to the Chromium build because some of the test targets (in browser_tests) depend on d8 and need to be able to built using the same toolchain. R=brett@chromium.org, jochen@chromium.org BUG= Committed: https://crrev.com/7d5d1570d9eb716f6f869274c0df277bc71328dd Cr-Commit-Position: refs/heads/master@{#30854}

Patch Set 1 #

Total comments: 1

Patch Set 2 : update license header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -47 lines) Patch
M BUILD.gn View 3 chunks +3 lines, -18 lines 0 comments Download
A + snapshot_toolchain.gni View 1 2 chunks +17 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dirk Pranke
Please take a look and let me know if I'm missing something or if there's ...
5 years, 3 months ago (2015-09-19 00:50:57 UTC) #1
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/1350223004/diff/1/snapshot_toolchain.gni File snapshot_toolchain.gni (right): https://codereview.chromium.org/1350223004/diff/1/snapshot_toolchain.gni#newcode1 snapshot_toolchain.gni:1: # Copyright 2014 The Chromium Authors. ...
5 years, 3 months ago (2015-09-21 15:10:49 UTC) #2
Dirk Pranke
On 2015/09/21 15:10:49, jochen wrote: > lgtm with comment > > https://codereview.chromium.org/1350223004/diff/1/snapshot_toolchain.gni > File snapshot_toolchain.gni ...
5 years, 3 months ago (2015-09-21 20:48:57 UTC) #3
Dirk Pranke
Header fixed.
5 years, 3 months ago (2015-09-22 01:14:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350223004/20001
5 years, 3 months ago (2015-09-22 01:14:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-22 02:28:38 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 02:28:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7d5d1570d9eb716f6f869274c0df277bc71328dd
Cr-Commit-Position: refs/heads/master@{#30854}

Powered by Google App Engine
This is Rietveld 408576698