Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 1350183005: X87: [runtime] Initial step towards switching Execution::Call to callable. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Initial step towards switching Execution::Call to callable. port d5bbd45f044ae6796c0d0f7bd8732069d74418de (r30808). oringial commit message: Currently Execution::Call (and friends) still duplicate a lot of the Call sequence logic that should be encapsulated in the Call and CallFunction builtins. So the plan now is to switch Execution::Call to accept any Callable and just pass that through to the Call builtin. BUG= Committed: https://crrev.com/e8ec4ede62e40e685687840c83d119dbe98dd2e1 Cr-Commit-Position: refs/heads/master@{#30828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-18 07:17:04 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-18 11:22:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350183005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350183005/1
5 years, 3 months ago (2015-09-18 11:22:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 11:59:36 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 11:59:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8ec4ede62e40e685687840c83d119dbe98dd2e1
Cr-Commit-Position: refs/heads/master@{#30828}

Powered by Google App Engine
This is Rietveld 408576698