Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1350173002: Improve GN duplicate name error. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve GN duplicate name error. Improve messaging when two targets generate the same output. Previous message: ERROR Duplicate rules for libfoo.so.TOC New message: ERROR at //BUILD.gn:24:1: Duplicate output file. shared_library("b456") { ^----------------------- Two or more targets generate the same output: libfoo.so.TOC This is normally the result of either overriding the output name or having two shared libraries or executables in different directories with the same name (since all such targets will be written to the root output directory). Collisions: //:b456 //:a123 See //BUILD.gn:21:1: Collision. shared_library("a123") { ^----------------------- Committed: https://crrev.com/bfd2deab3b5c8dea29671662116081a3878687a4 Cr-Commit-Position: refs/heads/master@{#349521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -4 lines) Patch
M tools/gn/ninja_build_writer.cc View 2 chunks +40 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 3 months ago (2015-09-17 22:02:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350173002/1
5 years, 3 months ago (2015-09-17 22:03:57 UTC) #4
jam
lgtm, thanks
5 years, 3 months ago (2015-09-17 22:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350173002/1
5 years, 3 months ago (2015-09-17 22:13:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 22:26:50 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 22:27:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfd2deab3b5c8dea29671662116081a3878687a4
Cr-Commit-Position: refs/heads/master@{#349521}

Powered by Google App Engine
This is Rietveld 408576698