Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1350163006: Cleanup: Pass std::string as const reference from ipc/ (Closed)

Created:
5 years, 3 months ago by ki.stfu
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from ipc/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=agl@chromium.org,darin@chromium.org,cpu@chromium.org,jeremy@chromium.org Committed: https://crrev.com/5e7a0f7968d389c782d56b87846c3cd34238193e Cr-Commit-Position: refs/heads/master@{#350942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M ipc/ipc_sync_message_unittest.cc View 3 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ki.stfu
5 years, 3 months ago (2015-09-20 20:11:33 UTC) #1
ki.stfu
ping
5 years, 2 months ago (2015-09-25 11:26:25 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
5 years, 2 months ago (2015-09-25 22:39:00 UTC) #4
agl
lgtm
5 years, 2 months ago (2015-09-25 22:43:29 UTC) #5
agl
lgtm
5 years, 2 months ago (2015-09-25 22:46:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350163006/1
5 years, 2 months ago (2015-09-25 22:47:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 23:17:30 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 23:18:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e7a0f7968d389c782d56b87846c3cd34238193e
Cr-Commit-Position: refs/heads/master@{#350942}

Powered by Google App Engine
This is Rietveld 408576698