Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1350143002: remove racy tests, as they assume the cache can't be purged behind their back (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove racy tests, as they assume the cache can't be purged behind their back If I explicitly purge the resource-cache after every DM, these tests fail (sporadically) . BUG=skia: Committed: https://skia.googlesource.com/skia/+/2ed7d50307d2c059b1c0a94747b3e1b9d49491e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -67 lines) Patch
M tests/SkResourceCacheTest.cpp View 2 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
reed1
ptal
5 years, 3 months ago (2015-09-17 20:20:13 UTC) #2
f(malita)
lgtm
5 years, 3 months ago (2015-09-17 20:20:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350143002/1
5 years, 3 months ago (2015-09-17 20:21:13 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:27:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ed7d50307d2c059b1c0a94747b3e1b9d49491e7

Powered by Google App Engine
This is Rietveld 408576698