Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1350093002: gn: Drop NaCl gcc-newlib toolchains (Closed)

Created:
5 years, 3 months ago by Roland McGrath
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Drop NaCl gcc-newlib toolchains NaCl's gcc-newlib toolchains are no longer supported and should never be used in bot builds at this point. The newlib use cases are now supported by the nacl-clang toolchain. The gcc-glibc toolchains remain as they were. R=dpranke@chromium.org, dschuff@chromium.org BUG= Committed: https://crrev.com/5927063a80783f2873f6be1e5948d9382028fff3 Cr-Commit-Position: refs/heads/master@{#349478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -45 lines) Patch
M build/toolchain/nacl/BUILD.gn View 1 chunk +2 lines, -45 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
Roland McGrath
5 years, 3 months ago (2015-09-17 18:03:00 UTC) #1
Derek Schuff
On 2015/09/17 18:03:00, Roland McGrath wrote: +sbc Will this eventually fall through to the SDK? ...
5 years, 3 months ago (2015-09-17 18:19:33 UTC) #4
Roland McGrath
This is entirely orthogonal to everything except GN builds. The support for the gcc-newlib toolchains ...
5 years, 3 months ago (2015-09-17 18:23:37 UTC) #5
Derek Schuff
lgtm
5 years, 3 months ago (2015-09-17 19:00:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350093002/1
5 years, 3 months ago (2015-09-17 19:13:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/101102)
5 years, 3 months ago (2015-09-17 19:24:00 UTC) #10
Roland McGrath
Needs OWNERS remove from Dirk...
5 years, 3 months ago (2015-09-17 19:29:38 UTC) #11
Roland McGrath
On 2015/09/17 19:29:38, Roland McGrath wrote: > Needs OWNERS remove from Dirk... by which I ...
5 years, 3 months ago (2015-09-17 19:29:50 UTC) #12
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-17 20:07:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350093002/1
5 years, 3 months ago (2015-09-17 20:08:45 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 20:13:58 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:14:42 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5927063a80783f2873f6be1e5948d9382028fff3
Cr-Commit-Position: refs/heads/master@{#349478}

Powered by Google App Engine
This is Rietveld 408576698