chrome/test/data/pdf/navigator_test.js - Issue 1350073002: PDFs viewed inside a <webview> should navigate the same as PDFs in tabs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/pdf/navigator_test.js

Issue 1350073002: PDFs viewed inside a <webview> should navigate the same as PDFs in tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass tabId to Navigator() instead of browserApi_. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: chrome/test/data/pdf/navigator_test.js

diff --git a/chrome/test/data/pdf/navigator_test.js b/chrome/test/data/pdf/navigator_test.js

index b9624edfc9a230250857fd7afc526e78c39893d4..a97ef1b7e63469a6d3dad3d424bd9a3b05fc8b72 100644

--- a/chrome/test/data/pdf/navigator_test.js

+++ b/chrome/test/data/pdf/navigator_test.js

@@ -90,7 +90,7 @@ var tests = [

var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();

var navigateInNewTabCallback = new NavigateInNewTabCallback();

- var navigator = new Navigator(url, viewport, paramsParser,

+ var navigator = new Navigator(0, url, viewport, paramsParser,

navigateInCurrentTabCallback.callback,

navigateInNewTabCallback.callback);

@@ -158,7 +158,7 @@ var tests = [

var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();

var navigateInNewTabCallback = new NavigateInNewTabCallback();

- var navigator = new Navigator(url, viewport, paramsParser,

+ var navigator = new Navigator(0, url, viewport, paramsParser,

navigateInCurrentTabCallback.callback,

navigateInNewTabCallback.callback);

@@ -265,7 +265,7 @@ var tests = [

var navigateInCurrentTabCallback = new NavigateInCurrentTabCallback();

var navigateInNewTabCallback = new NavigateInNewTabCallback();

- var navigator = new Navigator(url, viewport, paramsParser,

+ var navigator = new Navigator(0, url, viewport, paramsParser,

navigateInCurrentTabCallback.callback,

navigateInNewTabCallback.callback);

« chrome/browser/resources/pdf/pdf.js ('K') | « chrome/browser/resources/pdf/pdf.js ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »