Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: sdk/lib/isolate/isolate.dart

Issue 1350053002: Add "environment" parameter to spawnUri for String.fromEnvironment support. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/core/bool.dart ('K') | « sdk/lib/core/bool.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/isolate/isolate.dart
diff --git a/sdk/lib/isolate/isolate.dart b/sdk/lib/isolate/isolate.dart
index d5534ba71436bc0e4e10d6f12928165e9102b407..c67122049f1a8e543e21ceb2cbb1af7b176a25a8 100644
--- a/sdk/lib/isolate/isolate.dart
+++ b/sdk/lib/isolate/isolate.dart
@@ -237,6 +237,15 @@ class Isolate {
* WARNING: The [packageRoot] and [packages] parameters are not implemented
* on all platforms yet.
*
+ * The [environment] is a mapping from strings to strings which the
+ * spawned isolate uses when looking up [String.fromEnvironment] values.
+ * The system may add its own entries to environment as well.
+ * If `environment` is omitted, the spawned isolate has the same environment
+ * declarations as the spawning isolate.
+ *
+ * WARNING: The [environment] parameter is not implemented on all
+ * platforms yet.
+ *
* Returns a future that will complete with an [Isolate] instance if the
* spawning succeeded. It will complete with an error otherwise.
*/
@@ -245,12 +254,13 @@ class Isolate {
List<String> args,
var message,
{bool paused: false,
+ SendPort onExit,
+ SendPort onError,
+ bool errorsAreFatal,
bool checked,
+ Map<String, String> environment,
Uri packageRoot,
- Map<String, Uri> packages,
- bool errorsAreFatal,
- SendPort onExit,
- SendPort onError});
+ Map<String, Uri> packages});
/**
* Requests the isolate to pause.
« sdk/lib/core/bool.dart ('K') | « sdk/lib/core/bool.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698