Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1337)

Unified Diff: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart

Issue 1350053002: Add "environment" parameter to spawnUri for String.fromEnvironment support. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
index 70eda5b5e973708798fe729f2faf6b5eec296c82..a5d491ebaeb30fe6e0cfdcc3c7dfbd4f1cb6cc90 100644
--- a/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
+++ b/sdk/lib/_internal/js_runtime/lib/isolate_patch.dart
@@ -64,11 +64,14 @@ class Isolate {
Uri uri, List<String> args, var message,
{bool paused: false,
bool checked,
+ Map<String, String> environment,
Uri packageRoot,
Map<String, Uri> packages,
bool errorsAreFatal,
SendPort onExit,
SendPort onError}) {
+ if (environment != null) {
+ if (environment != null) throw new UnimplementedError("environment");
kevmoo 2015/09/17 16:55:14 missing close } on 'if' also: alignment
Siggi Cherem (dart-lang) 2015/09/17 17:06:57 since the condition is repeated here too, delete l
Lasse Reichstein Nielsen 2015/09/22 09:05:39 Absolutely, 'twas a bad paste error, at best.
if (packageRoot != null) throw new UnimplementedError("packageRoot");
if (packages != null) throw new UnimplementedError("packages");
bool forcePause = (errorsAreFatal != null) ||

Powered by Google App Engine
This is Rietveld 408576698