Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: tools/clang/empty_string/tests/test-original.cc

Issue 1350043004: Cleanup: Initialize Value from tools/gn by moving std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove Value(..., std::string&&) Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/empty_string/tests/test-original.cc
diff --git a/tools/clang/empty_string/tests/test-original.cc b/tools/clang/empty_string/tests/test-original.cc
index 2edb896cc631665ed77a51e5a2c62c5644011986..2375e8972e4c680e8604254bf36a774ab2d0a149 100644
--- a/tools/clang/empty_string/tests/test-original.cc
+++ b/tools/clang/empty_string/tests/test-original.cc
@@ -32,14 +32,14 @@ class TestInitializers {
// Tests for temporary std::strings.
void TestTemporaries(const std::string& reference_argument,
- const std::string value_argument) {
+ const std::string& value_argument) {
TestTemporaries("", "");
TestTemporaries(std::string(""), std::string(""));
}
// Tests for temporary std::wstrings.
void TestWideTemporaries(const std::wstring& reference_argument,
- const std::wstring value_argument) {
+ const std::wstring& value_argument) {
TestWideTemporaries(L"", L"");
TestWideTemporaries(std::wstring(L""), std::wstring(L""));
}
« no previous file with comments | « tools/clang/blink_gc_plugin/JsonWriter.h ('k') | tools/gn/value.h » ('j') | tools/gn/value.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698