testing/multiprocess_func_list.cc - Issue 1350043004: Cleanup: Initialize Value from tools/gn by moving std::string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/multiprocess_func_list.cc

Issue 1350043004: Cleanup: Initialize Value from tools/gn by moving std::string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Value(..., std::string&&) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/multiprocess_func_list.cc

diff --git a/testing/multiprocess_func_list.cc b/testing/multiprocess_func_list.cc

index 49ae07dd3e8d99d57ba806851b9e53474c95128c..f96c2b5079a254f30e220f68077139f7feea3ab7 100644

--- a/testing/multiprocess_func_list.cc

+++ b/testing/multiprocess_func_list.cc

@@ -40,7 +40,7 @@ AppendMultiProcessTest::AppendMultiProcessTest(

ProcessFunctions(main_func_ptr, setup_func_ptr);

}

-int InvokeChildProcessTest(std::string test_name) {

+int InvokeChildProcessTest(const std::string& test_name) {

MultiProcessTestMap& func_lookup_table = GetMultiprocessFuncMap();

MultiProcessTestMap::iterator it = func_lookup_table.find(test_name);

if (it != func_lookup_table.end()) {

« no previous file with comments | « testing/multiprocess_func_list.h ('k') | tools/clang/blink_gc_plugin/JsonWriter.h » ('j') | tools/gn/value.h » ('J')