Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1350043002: Fix git-freeze when using a commit hook which could reject a commit. (Closed)

Created:
5 years, 3 months ago by iannucci
Modified:
5 years, 3 months ago
Reviewers:
dnj, Vadim Sh., M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix git-freeze when using a commit hook which could reject a commit. This prevents `git rebase-update` from losing work when using a hook like pre-commit-go. R=dnj@chromium.org, vadimsh@chromium.org, maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M git_common.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
iannucci
5 years, 3 months ago (2015-09-17 08:40:45 UTC) #1
M-A Ruel
lgtm
5 years, 3 months ago (2015-09-17 10:45:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350043002/1
5 years, 3 months ago (2015-09-17 15:43:45 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 15:46:01 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296737

Powered by Google App Engine
This is Rietveld 408576698