Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 135003003: Add a UseCounter for the HTMLMediaElement.canPlayType keySystem argument (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Add a UseCounter for the HTMLMediaElement.canPlayType keySystem argument This has been replaced in the spec by MediaKeys.isTypeSupported: https://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html#extensions Add a counter now so that we have the data needed for removal when the new spec has been implemented. BUG=334941 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165312

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase! #

Patch Set 7 : rebase!! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-16 04:00:00 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 11 months ago (2014-01-16 18:10:06 UTC) #2
ddorwin
lgtm
6 years, 11 months ago (2014-01-16 18:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/135003003/1
6 years, 11 months ago (2014-01-16 18:37:54 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7824
6 years, 11 months ago (2014-01-16 21:31:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/135003003/1
6 years, 11 months ago (2014-01-17 00:12:39 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-17 01:04:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/135003003/170001
6 years, 11 months ago (2014-01-17 01:43:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17819
6 years, 11 months ago (2014-01-17 02:31:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/135003003/170001
6 years, 11 months ago (2014-01-17 02:58:20 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=17842
6 years, 11 months ago (2014-01-17 03:21:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/135003003/170001
6 years, 11 months ago (2014-01-17 04:29:20 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7903
6 years, 11 months ago (2014-01-17 04:52:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/135003003/480001
6 years, 11 months ago (2014-01-17 13:57:49 UTC) #14
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 15:12:45 UTC) #15
Message was sent while issue was closed.
Change committed as 165312

Powered by Google App Engine
This is Rietveld 408576698