Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 135003002: Make the apparance of pressed and hover state the same (Closed)

Created:
6 years, 11 months ago by oshima
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Make the appearance of pressed and hover states the same so that it's consistent with other menu items. Fix memory leak (SetImage does not transfer the ownership) BUG=333232 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/ui/views/toolbar/wrench_menu.cc View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
6 years, 11 months ago (2014-01-10 22:31:34 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-10 23:22:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/135003002/1
6 years, 11 months ago (2014-01-11 00:23:38 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 02:54:03 UTC) #4
Message was sent while issue was closed.
Change committed as 244423

Powered by Google App Engine
This is Rietveld 408576698