third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc - Issue 1350023003: Add a Mojo EDK for Chrome that uses one OS pipe per message pipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc

Issue 1350023003: Add a Mojo EDK for Chrome that uses one OS pipe per message pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more cleanup Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/edk/system/raw_channel_posix.cc ('K') | « third_party/mojo/src/mojo/edk/embedder/embedder.cc ('k') | third_party/mojo/src/mojo/edk/embedder/entrypoints.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc

diff --git a/third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc b/third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc

index 04634ac8e891cda574834142fc4c3aff8d92b86a..7e7c5f4d9239bf45798f70a39becaf1915d9c1e1 100644

--- a/third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc

+++ b/third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc

@@ -136,7 +136,7 @@ class EmbedderTest : public testing::Test {

}

private:

- void SetUp() override { test::InitWithSimplePlatformSupport(); }

+ void SetUp() override { Init(); }

void TearDown() override { EXPECT_TRUE(test::Shutdown()); }

@@ -499,7 +499,7 @@ MOJO_MULTIPROCESS_TEST_CHILD_TEST(MultiprocessMasterSlave) {

EXPECT_TRUE(client_platform_handle.is_valid());

base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart);

- test::InitWithSimplePlatformSupport();

+ Init();

{

mojo::test::ScopedSlaveIPCSupport ipc_support(

@@ -694,7 +694,7 @@ MOJO_MULTIPROCESS_TEST_CHILD_TEST(MultiprocessChannelsClient) {

EXPECT_TRUE(client_platform_handle.is_valid());

base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart);

- test::InitWithSimplePlatformSupport();

+ Init();

{

// TODO(vtl): This should eventually initialize a slave process instead,