Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Side by Side Diff: mojo/edk/system/dispatcher_unittest.cc

Issue 1350023003: Add a Mojo EDK for Chrome that uses one OS pipe per message pipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more cleanup Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "third_party/mojo/src/mojo/edk/system/dispatcher.h" 5 #include "mojo/edk/system/dispatcher.h"
6 6
7 #include "base/memory/ref_counted.h" 7 #include "base/memory/ref_counted.h"
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "base/synchronization/waitable_event.h" 9 #include "base/synchronization/waitable_event.h"
10 #include "base/threading/simple_thread.h" 10 #include "base/threading/simple_thread.h"
11 #include "mojo/edk/embedder/platform_shared_buffer.h"
12 #include "mojo/edk/system/waiter.h"
11 #include "mojo/public/cpp/system/macros.h" 13 #include "mojo/public/cpp/system/macros.h"
12 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
13 #include "third_party/mojo/src/mojo/edk/embedder/platform_shared_buffer.h"
14 #include "third_party/mojo/src/mojo/edk/system/memory.h"
15 #include "third_party/mojo/src/mojo/edk/system/waiter.h"
16 15
17 namespace mojo { 16 namespace mojo {
18 namespace system { 17 namespace edk {
19 namespace { 18 namespace {
20 19
21 // Trivial subclass that makes the constructor public. 20 // Trivial subclass that makes the constructor public.
22 class TrivialDispatcher final : public Dispatcher { 21 class TrivialDispatcher final : public Dispatcher {
23 public: 22 public:
24 TrivialDispatcher() {} 23 TrivialDispatcher() {}
25 24
26 Type GetType() const override { return Type::UNKNOWN; } 25 Type GetType() const override { return Type::UNKNOWN; }
27 26
28 private: 27 private:
29 friend class base::RefCountedThreadSafe<TrivialDispatcher>; 28 friend class base::RefCountedThreadSafe<TrivialDispatcher>;
30 ~TrivialDispatcher() override {} 29 ~TrivialDispatcher() override {}
31 30
32 scoped_refptr<Dispatcher> CreateEquivalentDispatcherAndCloseImplNoLock() 31 scoped_refptr<Dispatcher> CreateEquivalentDispatcherAndCloseImplNoLock()
33 override { 32 override {
34 mutex().AssertHeld(); 33 lock().AssertAcquired();
35 return scoped_refptr<Dispatcher>(new TrivialDispatcher()); 34 return scoped_refptr<Dispatcher>(new TrivialDispatcher());
36 } 35 }
37 36
38 MOJO_DISALLOW_COPY_AND_ASSIGN(TrivialDispatcher); 37 MOJO_DISALLOW_COPY_AND_ASSIGN(TrivialDispatcher);
39 }; 38 };
40 39
41 TEST(DispatcherTest, Basic) { 40 TEST(DispatcherTest, Basic) {
42 scoped_refptr<Dispatcher> d(new TrivialDispatcher()); 41 scoped_refptr<Dispatcher> d(new TrivialDispatcher());
43 42
44 EXPECT_EQ(Dispatcher::Type::UNKNOWN, d->GetType()); 43 EXPECT_EQ(Dispatcher::Type::UNKNOWN, d->GetType());
45 44
46 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 45 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
47 d->WriteMessage(NullUserPointer(), 0, nullptr, 46 d->WriteMessage(nullptr, 0, nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE));
48 MOJO_WRITE_MESSAGE_FLAG_NONE));
49 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 47 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
50 d->ReadMessage(NullUserPointer(), NullUserPointer(), nullptr, 48 d->ReadMessage(nullptr, nullptr, nullptr, nullptr,
51 nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE)); 49 MOJO_WRITE_MESSAGE_FLAG_NONE));
52 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 50 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
53 d->WriteData(NullUserPointer(), NullUserPointer(), 51 d->WriteData(nullptr, nullptr, MOJO_WRITE_DATA_FLAG_NONE));
54 MOJO_WRITE_DATA_FLAG_NONE));
55 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 52 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
56 d->BeginWriteData(NullUserPointer(), NullUserPointer(), 53 d->BeginWriteData(nullptr, nullptr, MOJO_WRITE_DATA_FLAG_NONE));
57 MOJO_WRITE_DATA_FLAG_NONE));
58 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndWriteData(0)); 54 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndWriteData(0));
59 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 55 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
60 d->ReadData(NullUserPointer(), NullUserPointer(), 56 d->ReadData(nullptr, nullptr, MOJO_READ_DATA_FLAG_NONE));
61 MOJO_READ_DATA_FLAG_NONE));
62 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 57 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
63 d->BeginReadData(NullUserPointer(), NullUserPointer(), 58 d->BeginReadData(nullptr, nullptr, MOJO_READ_DATA_FLAG_NONE));
64 MOJO_READ_DATA_FLAG_NONE));
65 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndReadData(0)); 59 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndReadData(0));
66 Waiter w; 60 Waiter w;
67 w.Init(); 61 w.Init();
68 HandleSignalsState hss; 62 HandleSignalsState hss;
69 EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION, 63 EXPECT_EQ(MOJO_RESULT_FAILED_PRECONDITION,
70 d->AddAwakable(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0, &hss)); 64 d->AddAwakable(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0, &hss));
71 EXPECT_EQ(0u, hss.satisfied_signals); 65 EXPECT_EQ(0u, hss.satisfied_signals);
72 EXPECT_EQ(0u, hss.satisfiable_signals); 66 EXPECT_EQ(0u, hss.satisfiable_signals);
73 // Okay to remove even if it wasn't added (or was already removed). 67 // Okay to remove even if it wasn't added (or was already removed).
74 hss = HandleSignalsState(); 68 hss = HandleSignalsState();
75 d->RemoveAwakable(&w, &hss); 69 d->RemoveAwakable(&w, &hss);
76 EXPECT_EQ(0u, hss.satisfied_signals); 70 EXPECT_EQ(0u, hss.satisfied_signals);
77 EXPECT_EQ(0u, hss.satisfiable_signals); 71 EXPECT_EQ(0u, hss.satisfiable_signals);
78 hss = HandleSignalsState(); 72 hss = HandleSignalsState();
79 d->RemoveAwakable(&w, &hss); 73 d->RemoveAwakable(&w, &hss);
80 EXPECT_EQ(0u, hss.satisfied_signals); 74 EXPECT_EQ(0u, hss.satisfied_signals);
81 EXPECT_EQ(0u, hss.satisfiable_signals); 75 EXPECT_EQ(0u, hss.satisfiable_signals);
82 76
83 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 77 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
84 78
85 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 79 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
86 d->WriteMessage(NullUserPointer(), 0, nullptr, 80 d->WriteMessage(nullptr, 0, nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE));
87 MOJO_WRITE_MESSAGE_FLAG_NONE));
88 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 81 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
89 d->ReadMessage(NullUserPointer(), NullUserPointer(), nullptr, 82 d->ReadMessage(nullptr, nullptr, nullptr, nullptr,
90 nullptr, MOJO_WRITE_MESSAGE_FLAG_NONE)); 83 MOJO_WRITE_MESSAGE_FLAG_NONE));
91 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 84 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
92 d->WriteData(NullUserPointer(), NullUserPointer(), 85 d->WriteData(nullptr, nullptr, MOJO_WRITE_DATA_FLAG_NONE));
93 MOJO_WRITE_DATA_FLAG_NONE));
94 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 86 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
95 d->BeginWriteData(NullUserPointer(), NullUserPointer(), 87 d->BeginWriteData(nullptr, nullptr, MOJO_WRITE_DATA_FLAG_NONE));
96 MOJO_WRITE_DATA_FLAG_NONE));
97 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndWriteData(0)); 88 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndWriteData(0));
98 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 89 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
99 d->ReadData(NullUserPointer(), NullUserPointer(), 90 d->ReadData(nullptr, nullptr, MOJO_READ_DATA_FLAG_NONE));
100 MOJO_READ_DATA_FLAG_NONE));
101 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 91 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
102 d->BeginReadData(NullUserPointer(), NullUserPointer(), 92 d->BeginReadData(nullptr, nullptr, MOJO_READ_DATA_FLAG_NONE));
103 MOJO_READ_DATA_FLAG_NONE));
104 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndReadData(0)); 93 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, d->EndReadData(0));
105 hss = HandleSignalsState(); 94 hss = HandleSignalsState();
106 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 95 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
107 d->AddAwakable(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0, &hss)); 96 d->AddAwakable(&w, ~MOJO_HANDLE_SIGNAL_NONE, 0, &hss));
108 EXPECT_EQ(0u, hss.satisfied_signals); 97 EXPECT_EQ(0u, hss.satisfied_signals);
109 EXPECT_EQ(0u, hss.satisfiable_signals); 98 EXPECT_EQ(0u, hss.satisfiable_signals);
110 hss = HandleSignalsState(); 99 hss = HandleSignalsState();
111 d->RemoveAwakable(&w, &hss); 100 d->RemoveAwakable(&w, &hss);
112 EXPECT_EQ(0u, hss.satisfied_signals); 101 EXPECT_EQ(0u, hss.satisfied_signals);
113 EXPECT_EQ(0u, hss.satisfiable_signals); 102 EXPECT_EQ(0u, hss.satisfiable_signals);
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 waiter_.Init(); 141 waiter_.Init();
153 switch (op_) { 142 switch (op_) {
154 case CLOSE: { 143 case CLOSE: {
155 MojoResult r = dispatcher_->Close(); 144 MojoResult r = dispatcher_->Close();
156 EXPECT_TRUE(r == MOJO_RESULT_OK || r == MOJO_RESULT_INVALID_ARGUMENT) 145 EXPECT_TRUE(r == MOJO_RESULT_OK || r == MOJO_RESULT_INVALID_ARGUMENT)
157 << "Result: " << r; 146 << "Result: " << r;
158 break; 147 break;
159 } 148 }
160 case WRITE_MESSAGE: 149 case WRITE_MESSAGE:
161 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 150 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
162 dispatcher_->WriteMessage(NullUserPointer(), 0, nullptr, 151 dispatcher_->WriteMessage(nullptr, 0, nullptr,
163 MOJO_WRITE_MESSAGE_FLAG_NONE)); 152 MOJO_WRITE_MESSAGE_FLAG_NONE));
164 break; 153 break;
165 case READ_MESSAGE: 154 case READ_MESSAGE:
166 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 155 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
167 dispatcher_->ReadMessage(NullUserPointer(), NullUserPointer(), 156 dispatcher_->ReadMessage(nullptr, nullptr, nullptr, nullptr,
168 nullptr, nullptr,
169 MOJO_WRITE_MESSAGE_FLAG_NONE)); 157 MOJO_WRITE_MESSAGE_FLAG_NONE));
170 break; 158 break;
171 case WRITE_DATA: 159 case WRITE_DATA:
172 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 160 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
173 dispatcher_->WriteData(NullUserPointer(), NullUserPointer(), 161 dispatcher_->WriteData(nullptr, nullptr,
174 MOJO_WRITE_DATA_FLAG_NONE)); 162 MOJO_WRITE_DATA_FLAG_NONE));
175 break; 163 break;
176 case BEGIN_WRITE_DATA: 164 case BEGIN_WRITE_DATA:
177 EXPECT_EQ( 165 EXPECT_EQ(
178 MOJO_RESULT_INVALID_ARGUMENT, 166 MOJO_RESULT_INVALID_ARGUMENT,
179 dispatcher_->BeginWriteData(NullUserPointer(), NullUserPointer(), 167 dispatcher_->BeginWriteData(nullptr, nullptr,
180 MOJO_WRITE_DATA_FLAG_NONE)); 168 MOJO_WRITE_DATA_FLAG_NONE));
181 break; 169 break;
182 case END_WRITE_DATA: 170 case END_WRITE_DATA:
183 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, dispatcher_->EndWriteData(0)); 171 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, dispatcher_->EndWriteData(0));
184 break; 172 break;
185 case READ_DATA: 173 case READ_DATA:
186 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, 174 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
187 dispatcher_->ReadData(NullUserPointer(), NullUserPointer(), 175 dispatcher_->ReadData(nullptr, nullptr,
188 MOJO_READ_DATA_FLAG_NONE)); 176 MOJO_READ_DATA_FLAG_NONE));
189 break; 177 break;
190 case BEGIN_READ_DATA: 178 case BEGIN_READ_DATA:
191 EXPECT_EQ( 179 EXPECT_EQ(
192 MOJO_RESULT_INVALID_ARGUMENT, 180 MOJO_RESULT_INVALID_ARGUMENT,
193 dispatcher_->BeginReadData(NullUserPointer(), NullUserPointer(), 181 dispatcher_->BeginReadData(nullptr, nullptr,
194 MOJO_READ_DATA_FLAG_NONE)); 182 MOJO_READ_DATA_FLAG_NONE));
195 break; 183 break;
196 case END_READ_DATA: 184 case END_READ_DATA:
197 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, dispatcher_->EndReadData(0)); 185 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, dispatcher_->EndReadData(0));
198 break; 186 break;
199 case DUPLICATE_BUFFER_HANDLE: { 187 case DUPLICATE_BUFFER_HANDLE: {
200 scoped_refptr<Dispatcher> unused; 188 scoped_refptr<Dispatcher> unused;
201 EXPECT_EQ( 189 EXPECT_EQ(
202 MOJO_RESULT_INVALID_ARGUMENT, 190 MOJO_RESULT_INVALID_ARGUMENT,
203 dispatcher_->DuplicateBufferHandle(NullUserPointer(), &unused)); 191 dispatcher_->DuplicateBufferHandle(nullptr, &unused));
204 break; 192 break;
205 } 193 }
206 case MAP_BUFFER: { 194 case MAP_BUFFER: {
207 scoped_ptr<embedder::PlatformSharedBufferMapping> unused; 195 scoped_ptr<PlatformSharedBufferMapping> unused;
208 EXPECT_EQ( 196 EXPECT_EQ(
209 MOJO_RESULT_INVALID_ARGUMENT, 197 MOJO_RESULT_INVALID_ARGUMENT,
210 dispatcher_->MapBuffer(0u, 0u, MOJO_MAP_BUFFER_FLAG_NONE, &unused)); 198 dispatcher_->MapBuffer(0u, 0u, MOJO_MAP_BUFFER_FLAG_NONE, &unused));
211 break; 199 break;
212 } 200 }
213 case ADD_WAITER: { 201 case ADD_WAITER: {
214 HandleSignalsState hss; 202 HandleSignalsState hss;
215 MojoResult r = dispatcher_->AddAwakable( 203 MojoResult r = dispatcher_->AddAwakable(
216 &waiter_, ~MOJO_HANDLE_SIGNAL_NONE, 0, &hss); 204 &waiter_, ~MOJO_HANDLE_SIGNAL_NONE, 0, &hss);
217 EXPECT_TRUE(r == MOJO_RESULT_FAILED_PRECONDITION || 205 EXPECT_TRUE(r == MOJO_RESULT_FAILED_PRECONDITION ||
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 } 284 }
297 // Kicks off real work on the threads: 285 // Kicks off real work on the threads:
298 event.Signal(); 286 event.Signal();
299 } // Joins all the threads. 287 } // Joins all the threads.
300 288
301 EXPECT_EQ(MOJO_RESULT_OK, d->Close()); 289 EXPECT_EQ(MOJO_RESULT_OK, d->Close());
302 } 290 }
303 } 291 }
304 292
305 } // namespace 293 } // namespace
306 } // namespace system 294 } // namespace edk
307 } // namespace mojo 295 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698