Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1350023002: Revert of Extract some stuff into PackageManager (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract some stuff into PackageManager (patchset #8 id:140001 of https://codereview.chromium.org/1352663002/ ) Reason for revert: Compilation error in test_package_manager.h FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/mojo/shell/mojo_shell_unittests/test_package_manager.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_OPENSSL=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_HIDPI=1 -DENABLE_TOPCHROME_MD=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_BACKGROUND=1 -DENABLE_PRE_SYNC_BACKUP -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=245965-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=0 -DGTEST_HAS_RTTI=0 -DUNIT_TEST -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/mojo/src -Igen/third_party/mojo/src -I../../testing/gtest/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -m64 -march=x86-64 -funwind-tables -fPIC -pipe -pthread -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-reserved-user-defined-literal -Wno-inconsistent-missing-override -Wno-shift-negative-value -O2 -fno-ident -fdata-sections -ffunction-sections -g1 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wthread-safety -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../mojo/shell/test_package_manager.cc -o obj/mojo/shell/mojo_shell_unittests/test_package_manager.o In file included from ../../mojo/shell/test_package_manager.cc:5: ../../mojo/shell/test_package_manager.h:23:32: error: [chromium-style] Overriding method must be marked with 'override' or 'final'. virtual ~TestPackageManager(); ^ override 1 error generated. Original issue's description: > Extract some stuff into PackageManager: > > - content handler determination from ApplicationManager::HandleFetchCallback > - content handler registration > - renames BaseApplicationFetcher to PackageManagerImpl. > > R=yzshen@chromium.org > BUG= > > Committed: https://crrev.com/59e4ed2dd7f05972f687d628df0ba9c9cc35eb97 > Cr-Commit-Position: refs/heads/master@{#349357} TBR=yzshen@chromium.org,ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -563 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/app/core_services_initialization.cc View 2 chunks +1 line, -3 lines 0 comments Download
M mandoline/app/desktop/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/fetcher/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/fetcher/about_fetcher_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
A mojo/fetcher/base_application_fetcher.h View 1 chunk +41 lines, -0 lines 0 comments Download
A mojo/fetcher/base_application_fetcher.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M mojo/mojo_shell.gyp View 4 chunks +2 lines, -5 lines 0 comments Download
D mojo/package_manager/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/package_manager/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/package_manager/package_manager_impl.h View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/package_manager/package_manager_impl.cc View 1 chunk +0 lines, -172 lines 0 comments Download
M mojo/runner/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/runner/context.h View 3 chunks +0 lines, -10 lines 0 comments Download
M mojo/runner/context.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/BUILD.gn View 3 chunks +1 line, -3 lines 0 comments Download
A mojo/shell/application_fetcher.h View 1 chunk +43 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.h View 5 chunks +20 lines, -3 lines 0 comments Download
M mojo/shell/application_manager.cc View 6 chunks +98 lines, -37 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 10 chunks +33 lines, -32 lines 0 comments Download
M mojo/shell/capability_filter_unittest.cc View 7 chunks +18 lines, -14 lines 0 comments Download
D mojo/shell/package_manager.h View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/shell/test_package_manager.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/shell/test_package_manager.cc View 1 chunk +0 lines, -54 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
yosin_UTC9
Created Revert of Extract some stuff into PackageManager
5 years, 3 months ago (2015-09-17 06:18:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1350023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1350023002/1
5 years, 3 months ago (2015-09-17 06:18:17 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 06:18:51 UTC) #4
Failed to apply patch for mojo/package_manager/DEPS:
While running git apply --index -3 -p1;
  fatal: unrecognized input

Patch:       mojo/package_manager/DEPS
Index: mojo/package_manager/DEPS
diff --git a/mojo/package_manager/DEPS b/mojo/package_manager/DEPS

Powered by Google App Engine
This is Rietveld 408576698