Cache gpu suitability in DisplayItemList, remove SetUnsuitable...ForTesting

cc/layers/picture_layer_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer.h"
 
 #include "base/thread_task_runner_handle.h"
 #include "cc/layers/content_layer_client.h"
 #include "cc/layers/picture_layer_impl.h"
+#include "cc/test/fake_display_list_recording_source.h"
 #include "cc/test/fake_layer_tree_host.h"
 #include "cc/test/fake_picture_layer.h"
 #include "cc/test/fake_picture_layer_impl.h"
 #include "cc/test/fake_proxy.h"
 #include "cc/test/test_shared_bitmap_manager.h"
 #include "cc/test/test_task_graph_runner.h"
 #include "cc/trees/single_thread_proxy.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
@@ skipping 50 matching lines @@
 
     layer->PushPropertiesTo(layer_impl.get());
     EXPECT_FALSE(layer_impl->CanHaveTilings());
     EXPECT_TRUE(layer_impl->bounds() == gfx::Size(0, 0));
     EXPECT_EQ(gfx::Size(), layer_impl->raster_source()->GetSize());
     EXPECT_FALSE(layer_impl->raster_source()->HasRecordings());
   }
 }
 
 TEST(PictureLayerTest, SuitableForGpuRasterization) {
+  scoped_ptr<FakeDisplayListRecordingSource> fake_recording_source(
+      new FakeDisplayListRecordingSource(gfx::Size(100, 100)));
   MockContentLayerClient client;
-  scoped_refptr<PictureLayer> layer =
-      PictureLayer::Create(LayerSettings(), &client);
+  scoped_refptr<FakePictureLayer> layer =
+      FakePictureLayer::CreateWithRecordingSource(LayerSettings(), &client,
+                                                  fake_recording_source.Pass());
+
   FakeLayerTreeHostClient host_client(FakeLayerTreeHostClient::DIRECT_3D);
   TestTaskGraphRunner task_graph_runner;
   scoped_ptr<FakeLayerTreeHost> host =
       FakeLayerTreeHost::Create(&host_client, &task_graph_runner);
   host->SetRootLayer(layer);
-  RecordingSource* recording_source = layer->GetRecordingSourceForTesting();
+  FakeDisplayListRecordingSource* recording_source =

[danakj, 2015/09/16 23:04:49]

nit: can you grab this pointer before you Pass it to the layer, then you don't
need to cast it. typically i'd do like:

scoped_ptr<T> foo_t_owned(new T);
T* foo_t = foo_t_owned.get();
Blah(foo_t_owned.Pass());

[pdr., 2015/09/17 20:52:45]

Good idea. Done.

+      static_cast<FakeDisplayListRecordingSource*>(
+          layer->GetRecordingSourceForTesting());
 
   // Layer is suitable for gpu rasterization by default.
   EXPECT_TRUE(recording_source->IsSuitableForGpuRasterization());
   EXPECT_TRUE(layer->IsSuitableForGpuRasterization());
 
   // Veto gpu rasterization.
-  recording_source->SetUnsuitableForGpuRasterizationForTesting();
+  recording_source->SetUnsuitableForGpuRasterization();
   EXPECT_FALSE(recording_source->IsSuitableForGpuRasterization());

[hendrikw, 2015/09/16 23:15:57]

This part of the test is a bit weird for me, we set
force_unsuitable_for_gpu_rasterization_ to true (which only exists in the fake
version), then we call IsSuitableForGpuRasterization, which the fake version
checks force_unsuitable_for_gpu_rasterization_ and returns false.

What I mean is, this test is testing fake code.

The old code tested real code.

[danakj, 2015/09/16 23:20:50]

Ya this EXPECT could go away. This test is basically checking that Layer asks
the recording source. I'm not sure how valuable that is, but it doesn't hurt.

   EXPECT_FALSE(layer->IsSuitableForGpuRasterization());
 }
 
 // PicturePile uses the source frame number as a unit for measuring invalidation
 // frequency. When a pile moves between compositors, the frame number increases
 // non-monotonically. This executes that code path under this scenario allowing
 // for the code to verify correctness with DCHECKs.
 TEST(PictureLayerTest, NonMonotonicSourceFrameNumber) {
   LayerTreeSettings settings;
   settings.single_thread_proxy_scheduler = false;
@@ skipping 45 matching lines @@
   // Do a main frame, record the picture layers. The frame number has changed
   // non-monotonically.
   layer->SetNeedsDisplay();
   host2->Composite(base::TimeTicks::Now());
   EXPECT_EQ(3, layer->update_count());
   EXPECT_EQ(1, host2->source_frame_number());
 }
 
 }  // namespace
 }  // namespace cc