Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 1349843002: Make pdfium_embeddertests link in debug component builds. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make pdfium_embeddertests link in debug component builds. Target v8 has: 'direct_dependent_settings': { 'defines': [ 'V8_SHARED', 'USING_V8_SHARED', ], }, For this to work, targets using v8 headers have to depend on v8 directly, else the V8_EXPORT macro won't work. Add a direct dependency on v8. BUG=none TEST=do a debug component build of pdfium_embeddertests on Win, should work without linker errors R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6f34355e9d091fd4e031e9354fdfa778000b0d4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
I guess the most interesting bit here is that these tests didn't build (at least ...
5 years, 3 months ago (2015-09-16 20:48:53 UTC) #2
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-16 20:52:59 UTC) #3
Nico
5 years, 3 months ago (2015-09-16 20:53:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f34355e9d091fd4e031e9354fdfa778000b0d4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698