Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/gn/value.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/value.h
diff --git a/tools/gn/value.h b/tools/gn/value.h
index 44fba4adb2af16a450eda4608a767ed178a2bb1e..6556f8d6d9a73cda76260cc322e54f1e71876fcc 100644
--- a/tools/gn/value.h
+++ b/tools/gn/value.h
@@ -32,7 +32,8 @@ class Value {
Value(const ParseNode* origin, Type t);
Value(const ParseNode* origin, bool bool_val);
Value(const ParseNode* origin, int64_t int_val);
- Value(const ParseNode* origin, std::string str_val);
+ Value(const ParseNode* origin, const std::string& str_val);
+ Value(const ParseNode* origin, std::string&& str_val) noexcept;
Value(const ParseNode* origin, const char* str_val);
// Values "shouldn't" have null scopes when type == Scope, so be sure to
// always set one. However, this is not asserted since there are some
« no previous file with comments | « tools/clang/empty_string/tests/test-original.cc ('k') | tools/gn/value.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698